Skip to content

Commit

Permalink
reset: renesas: Check return value of reset_control_deassert()
Browse files Browse the repository at this point in the history
Deasserting the reset is vital, therefore bail out in case of error.

Suggested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://lore.kernel.org/r/b2131908-0110-006b-862f-080517f3e2d8@gmail.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
  • Loading branch information
Heiner Kallweit authored and Philipp Zabel committed Apr 4, 2022
1 parent 8362f52 commit da18980
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/reset/reset-rzg2l-usbphy-ctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ static int rzg2l_usbphy_ctrl_probe(struct platform_device *pdev)
return dev_err_probe(dev, PTR_ERR(priv->rstc),
"failed to get reset\n");

reset_control_deassert(priv->rstc);
error = reset_control_deassert(priv->rstc);
if (error)
return error;

priv->rcdev.ops = &rzg2l_usbphy_ctrl_reset_ops;
priv->rcdev.of_reset_n_cells = 1;
Expand Down

0 comments on commit da18980

Please sign in to comment.