Skip to content

Commit

Permalink
bcache: silence static checker warning
Browse files Browse the repository at this point in the history
In olden times, closure_return() used to have a hidden return built in.
We removed the hidden return but forgot to add a new return here.  If
"c" were NULL we would oops on the next line, but fortunately "c" is
never NULL.  Let's just remove the if statement.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Dan Carpenter authored and Jens Axboe committed Sep 6, 2017
1 parent 9baf309 commit da22f0e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/md/bcache/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1376,9 +1376,6 @@ static void cache_set_flush(struct closure *cl)
struct btree *b;
unsigned i;

if (!c)
closure_return(cl);

bch_cache_accounting_destroy(&c->accounting);

kobject_put(&c->internal);
Expand Down

0 comments on commit da22f0e

Please sign in to comment.