Skip to content

Commit

Permalink
iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'
Browse files Browse the repository at this point in the history
'iommu_group_get_for_dev()' never returns NULL, so this test can be
simplified a bit.

This way, the test is consistent with all other calls to
'iommu_group_get_for_dev()'.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
  • Loading branch information
Christophe JAILLET authored and Joerg Roedel committed Oct 15, 2019
1 parent 4f5cafb commit da6b05d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/iommu/qcom_iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,8 @@ static int qcom_iommu_add_device(struct device *dev)
}

group = iommu_group_get_for_dev(dev);
if (IS_ERR_OR_NULL(group))
return PTR_ERR_OR_ZERO(group);
if (IS_ERR(group))
return PTR_ERR(group);

iommu_group_put(group);
iommu_device_link(&qcom_iommu->iommu, dev);
Expand Down

0 comments on commit da6b05d

Please sign in to comment.