Skip to content

Commit

Permalink
kconfig: qconf: move conf_read() before drawing tree pain
Browse files Browse the repository at this point in the history
The constructor of ConfigMainWindow() calls show*View(), which needs
to calculate symbol values. conf_read() must be called before that.

Fixes: 060e05c ("kconfig: qconf: remove initial call to conf_changed()")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
  • Loading branch information
Masahiro Yamada committed Oct 1, 2024
1 parent 8d09554 commit da724c3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/kconfig/qconf.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1505,6 +1505,8 @@ ConfigMainWindow::ConfigMainWindow(void)
connect(helpText, &ConfigInfoView::menuSelected,
this, &ConfigMainWindow::setMenuLink);

conf_read(NULL);

QString listMode = configSettings->value("/listMode", "symbol").toString();
if (listMode == "single")
showSingleView();
Expand Down Expand Up @@ -1906,8 +1908,6 @@ int main(int ac, char** av)
configApp->connect(configApp, SIGNAL(lastWindowClosed()), SLOT(quit()));
configApp->connect(configApp, SIGNAL(aboutToQuit()), v, SLOT(saveSettings()));

conf_read(NULL);

v->show();
configApp->exec();

Expand Down

0 comments on commit da724c3

Please sign in to comment.