Skip to content

Commit

Permalink
of: Fixes for OF probing on little endian systems
Browse files Browse the repository at this point in the history
Fixes for sdhci-of and ipmi drivers.

Auditing all drivers using of_get_property did not find other
occurrences likely to be used on LE platforms.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Rob Herring authored and Grant Likely committed Jan 3, 2011
1 parent 236cdc7 commit da81c3b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions drivers/char/ipmi/ipmi_si_intf.c
Original file line number Diff line number Diff line change
Expand Up @@ -2546,7 +2546,7 @@ static int __devinit ipmi_of_probe(struct platform_device *dev,
{
struct smi_info *info;
struct resource resource;
const int *regsize, *regspacing, *regshift;
const __be32 *regsize, *regspacing, *regshift;
struct device_node *np = dev->dev.of_node;
int ret;
int proplen;
Expand Down Expand Up @@ -2599,9 +2599,9 @@ static int __devinit ipmi_of_probe(struct platform_device *dev,

info->io.addr_data = resource.start;

info->io.regsize = regsize ? *regsize : DEFAULT_REGSIZE;
info->io.regspacing = regspacing ? *regspacing : DEFAULT_REGSPACING;
info->io.regshift = regshift ? *regshift : 0;
info->io.regsize = regsize ? be32_to_cpup(regsize) : DEFAULT_REGSIZE;
info->io.regspacing = regspacing ? be32_to_cpup(regspacing) : DEFAULT_REGSPACING;
info->io.regshift = regshift ? be32_to_cpup(regshift) : 0;

info->irq = irq_of_parse_and_map(dev->dev.of_node, 0);
info->dev = &dev->dev;
Expand Down
4 changes: 2 additions & 2 deletions drivers/mmc/host/sdhci-of-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static int __devinit sdhci_of_probe(struct platform_device *ofdev,
struct sdhci_of_data *sdhci_of_data = match->data;
struct sdhci_host *host;
struct sdhci_of_host *of_host;
const u32 *clk;
const __be32 *clk;
int size;
int ret;

Expand Down Expand Up @@ -166,7 +166,7 @@ static int __devinit sdhci_of_probe(struct platform_device *ofdev,

clk = of_get_property(np, "clock-frequency", &size);
if (clk && size == sizeof(*clk) && *clk)
of_host->clock = *clk;
of_host->clock = be32_to_cpup(clk);

ret = sdhci_add_host(host);
if (ret)
Expand Down

0 comments on commit da81c3b

Please sign in to comment.