Skip to content

Commit

Permalink
clk: versatile: Add of_node_put() before return statement
Browse files Browse the repository at this point in the history
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.

Fix a potential memory leak in clk-impd1.c by inserting
of_node_put() before a return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Sumera Priyadarsini authored and Stephen Boyd committed Sep 10, 2020
1 parent 73a203b commit da9c43d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/clk/versatile/clk-impd1.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev)

for_each_available_child_of_node(np, child) {
ret = integrator_impd1_clk_spawn(dev, np, child);
if (ret)
if (ret) {
of_node_put(child);
break;
}
}

return ret;
Expand Down

0 comments on commit da9c43d

Please sign in to comment.