Skip to content

Commit

Permalink
vsock: add 'struct vsock_sock *' param to vsock_core_get_transport()
Browse files Browse the repository at this point in the history
Since now the 'struct vsock_sock' object contains a pointer to
the transport, this patch adds a parameter to the
vsock_core_get_transport() to return the right transport
assigned to the socket.

This patch modifies also the virtio_transport_get_ops(), that
uses the vsock_core_get_transport(), adding the
'struct vsock_sock *' parameter.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stefano Garzarella authored and David S. Miller committed Nov 15, 2019
1 parent 4c7246d commit daabfbc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion include/net/af_vsock.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ static inline int vsock_core_init(const struct vsock_transport *t)
void vsock_core_exit(void);

/* The transport may downcast this to access transport-specific functions */
const struct vsock_transport *vsock_core_get_transport(void);
const struct vsock_transport *vsock_core_get_transport(struct vsock_sock *vsk);

/**** UTILS ****/

Expand Down
7 changes: 2 additions & 5 deletions net/vmw_vsock/af_vsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -1999,12 +1999,9 @@ void vsock_core_exit(void)
}
EXPORT_SYMBOL_GPL(vsock_core_exit);

const struct vsock_transport *vsock_core_get_transport(void)
const struct vsock_transport *vsock_core_get_transport(struct vsock_sock *vsk)
{
/* vsock_register_mutex not taken since only the transport uses this
* function and only while registered.
*/
return transport_single;
return vsk->transport;
}
EXPORT_SYMBOL_GPL(vsock_core_get_transport);

Expand Down
9 changes: 5 additions & 4 deletions net/vmw_vsock/virtio_transport_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@
/* Threshold for detecting small packets to copy */
#define GOOD_COPY_LEN 128

static const struct virtio_transport *virtio_transport_get_ops(void)
static const struct virtio_transport *
virtio_transport_get_ops(struct vsock_sock *vsk)
{
const struct vsock_transport *t = vsock_core_get_transport();
const struct vsock_transport *t = vsock_core_get_transport(vsk);

return container_of(t, struct virtio_transport, transport);
}
Expand Down Expand Up @@ -168,7 +169,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,
struct virtio_vsock_pkt *pkt;
u32 pkt_len = info->pkt_len;

src_cid = virtio_transport_get_ops()->transport.get_local_cid();
src_cid = virtio_transport_get_ops(vsk)->transport.get_local_cid();
src_port = vsk->local_addr.svm_port;
if (!info->remote_cid) {
dst_cid = vsk->remote_addr.svm_cid;
Expand Down Expand Up @@ -201,7 +202,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk,

virtio_transport_inc_tx_pkt(vvs, pkt);

return virtio_transport_get_ops()->send_pkt(pkt);
return virtio_transport_get_ops(vsk)->send_pkt(pkt);
}

static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs,
Expand Down

0 comments on commit daabfbc

Please sign in to comment.