Skip to content

Commit

Permalink
regulator: core: Add of_node_put() before return
Browse files Browse the repository at this point in the history
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return in
two places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804162023.5673-1-nishkadg.linux@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Nishka Dasgupta authored and Mark Brown committed Aug 5, 2019
1 parent 4724193 commit db2a173
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/regulator/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,12 @@ static struct device_node *of_get_child_regulator(struct device_node *parent,

if (!regnode) {
regnode = of_get_child_regulator(child, prop_name);
if (regnode)
if (regnode) {
of_node_put(child);
return regnode;
}
} else {
of_node_put(child);
return regnode;
}
}
Expand Down

0 comments on commit db2a173

Please sign in to comment.