Skip to content

Commit

Permalink
drm/i915: Allocate a crtc_state also when the crtc is being disabled
Browse files Browse the repository at this point in the history
For consistency, allocate a new crtc_state for a crtc that is being
disabled. Previously only the enabled value of the current state would
change.

v2: Rebase on v5 of previous patch. (Ander)

Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
[danvet: Resolve rebase conflict.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Ander Conselvan de Oliveira authored and Daniel Vetter committed Mar 26, 2015
1 parent 83a5715 commit db7542d
Showing 1 changed file with 22 additions and 8 deletions.
30 changes: 22 additions & 8 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -11291,28 +11291,42 @@ intel_modeset_compute_config(struct drm_crtc *crtc,
unsigned *prepare_pipes,
unsigned *disable_pipes)
{
struct drm_device *dev = crtc->dev;
struct intel_crtc_state *pipe_config = NULL;
struct intel_crtc *intel_crtc;

intel_modeset_affected_pipes(crtc, modeset_pipes,
prepare_pipes, disable_pipes);

if ((*modeset_pipes) == 0)
return NULL;
for_each_intel_crtc_masked(dev, *disable_pipes, intel_crtc) {
pipe_config = intel_atomic_get_crtc_state(state, intel_crtc);
if (IS_ERR(pipe_config))
return pipe_config;

pipe_config->base.enable = false;
}

/*
* Note this needs changes when we start tracking multiple modes
* and crtcs. At that point we'll need to compute the whole config
* (i.e. one pipe_config for each crtc) rather than just the one
* for this crtc.
*/
pipe_config = intel_modeset_pipe_config(crtc, fb, mode, state);
if (IS_ERR(pipe_config))
return pipe_config;
for_each_intel_crtc_masked(dev, *modeset_pipes, intel_crtc) {
/* FIXME: For now we still expect modeset_pipes has at most
* one bit set. */
if (WARN_ON(&intel_crtc->base != crtc))
continue;

intel_dump_pipe_config(to_intel_crtc(crtc), pipe_config,
"[modeset]");
pipe_config = intel_modeset_pipe_config(crtc, fb, mode, state);
if (IS_ERR(pipe_config))
return pipe_config;

return pipe_config;
intel_dump_pipe_config(to_intel_crtc(crtc), pipe_config,
"[modeset]");
}

return intel_atomic_get_crtc_state(state, to_intel_crtc(crtc));;
}

static int __intel_set_mode_setup_plls(struct drm_device *dev,
Expand Down

0 comments on commit db7542d

Please sign in to comment.