Skip to content

Commit

Permalink
Merge branch 'netdevsim-implement-devlink-dev_info-op'
Browse files Browse the repository at this point in the history
Jiri Pirko says:

====================
netdevsim: implement devlink dev_info op

Initial implementation of devlink dev_info op - just driver name is
filled up and sent to user. Bundled with selftest.
====================

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Oct 7, 2019
2 parents 82a843d + 62ede55 commit db7fe42
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 1 deletion.
8 changes: 8 additions & 0 deletions drivers/net/netdevsim/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,13 @@ static int nsim_dev_reload_up(struct devlink *devlink,
return nsim_dev_reload_create(nsim_dev, extack);
}

static int nsim_dev_info_get(struct devlink *devlink,
struct devlink_info_req *req,
struct netlink_ext_ack *extack)
{
return devlink_info_driver_name_put(req, DRV_NAME);
}

#define NSIM_DEV_FLASH_SIZE 500000
#define NSIM_DEV_FLASH_CHUNK_SIZE 1000
#define NSIM_DEV_FLASH_CHUNK_TIME_MS 10
Expand Down Expand Up @@ -603,6 +610,7 @@ nsim_dev_devlink_trap_action_set(struct devlink *devlink,
static const struct devlink_ops nsim_dev_devlink_ops = {
.reload_down = nsim_dev_reload_down,
.reload_up = nsim_dev_reload_up,
.info_get = nsim_dev_info_get,
.flash_update = nsim_dev_flash_update,
.trap_init = nsim_dev_devlink_trap_init,
.trap_action_set = nsim_dev_devlink_trap_action_set,
Expand Down
21 changes: 20 additions & 1 deletion tools/testing/selftests/drivers/net/netdevsim/devlink.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
lib_dir=$(dirname $0)/../../../net/forwarding

ALL_TESTS="fw_flash_test params_test regions_test reload_test \
netns_reload_test resource_test"
netns_reload_test resource_test dev_info_test"
NUM_NETIFS=0
source $lib_dir/lib.sh

Expand Down Expand Up @@ -284,6 +284,25 @@ resource_test()
log_test "resource test"
}

info_get()
{
local name=$1

cmd_jq "devlink dev info $DL_HANDLE -j" ".[][][\"$name\"]" "-e"
}

dev_info_test()
{
RET=0

driver=$(info_get "driver")
check_err $? "Failed to get driver name"
[ "$driver" == "netdevsim" ]
check_err $? "Unexpected driver name $driver"

log_test "dev_info test"
}

setup_prepare()
{
modprobe netdevsim
Expand Down

0 comments on commit db7fe42

Please sign in to comment.