Skip to content

Commit

Permalink
qlge: Move reset logic into asic_reset_worker func.
Browse files Browse the repository at this point in the history
Get rid of extraneous ql_cycle_adapter.  It's only called from the one
place.

Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ron Mercer authored and David S. Miller committed Mar 10, 2009
1 parent 1a77733 commit db98812
Showing 1 changed file with 18 additions and 23 deletions.
41 changes: 18 additions & 23 deletions drivers/net/qlge/qlge_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -3263,28 +3263,6 @@ static int ql_adapter_up(struct ql_adapter *qdev)
return err;
}

static int ql_cycle_adapter(struct ql_adapter *qdev)
{
int status;

status = ql_adapter_down(qdev);
if (status)
goto error;

status = ql_adapter_up(qdev);
if (status)
goto error;

return status;
error:
QPRINTK(qdev, IFUP, ALERT,
"Driver up/down cycle failed, closing device\n");
rtnl_lock();
dev_close(qdev->ndev);
rtnl_unlock();
return status;
}

static void ql_release_adapter_resources(struct ql_adapter *qdev)
{
ql_free_mem_resources(qdev);
Expand Down Expand Up @@ -3617,7 +3595,24 @@ static void ql_asic_reset_work(struct work_struct *work)
{
struct ql_adapter *qdev =
container_of(work, struct ql_adapter, asic_reset_work.work);
ql_cycle_adapter(qdev);
int status;

status = ql_adapter_down(qdev);
if (status)
goto error;

status = ql_adapter_up(qdev);
if (status)
goto error;

return;
error:
QPRINTK(qdev, IFUP, ALERT,
"Driver up/down cycle failed, closing device\n");
rtnl_lock();
set_bit(QL_ADAPTER_UP, &qdev->flags);
dev_close(qdev->ndev);
rtnl_unlock();
}

static struct nic_operations qla8012_nic_ops = {
Expand Down

0 comments on commit db98812

Please sign in to comment.