Skip to content

Commit

Permalink
firewire: cdev: remove unneeded reference
Browse files Browse the repository at this point in the history
For outbound transactions, the IDR's and the callback's references now
have exactly the same lifetime, so we do not need both of them.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: "Stefan Richter" <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Clemens Ladisch authored and Stefan Richter committed Jan 23, 2011
1 parent 5a5e62d commit dbc9880
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/firewire/core-cdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,6 @@ static void complete_transaction(struct fw_card *card, int rcode,

/* Drop the idr's reference */
client_put(client);
/* Drop the transaction callback's reference */
client_put(client);
}

static int init_request(struct client *client,
Expand Down Expand Up @@ -601,9 +599,6 @@ static int init_request(struct client *client,
if (ret < 0)
goto failed;

/* Get a reference for the transaction callback */
client_get(client);

fw_send_request(client->device->card, &e->r.transaction,
request->tcode, destination_id, request->generation,
speed, request->offset, e->response.data,
Expand Down

0 comments on commit dbc9880

Please sign in to comment.