Skip to content

Commit

Permalink
Merge tag 'gnss-4.20-rc6' of https://git.kernel.org/pub/scm/linux/ker…
Browse files Browse the repository at this point in the history
…nel/git/johan/gnss into char-misc-linus

Johan writes:

GNSS fixes for 4.20-rc6

Here's a fix for a broken activation retry loop in the sirf driver.

Included are also two MAINTAINERS updates.

All have been in linux-next with no reported issues.

Signed-off-by: Johan Hovold <johan@kernel.org>

* tag 'gnss-4.20-rc6' of https://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss:
  MAINTAINERS: exclude gnss from SIRFPRIMA2 regex matching
  MAINTAINERS: add gnss scm tree
  gnss: sirf: fix activation retry handling
  • Loading branch information
Greg Kroah-Hartman committed Dec 7, 2018
2 parents 37c2578 + 63cea1f commit dbde117
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 2 additions & 0 deletions MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,7 @@ F: drivers/clk/sirf/
F: drivers/clocksource/timer-prima2.c
F: drivers/clocksource/timer-atlas7.c
N: [^a-z]sirf
X: drivers/gnss

ARM/EBSA110 MACHINE SUPPORT
M: Russell King <linux@armlinux.org.uk>
Expand Down Expand Up @@ -6316,6 +6317,7 @@ F: include/uapi/linux/gigaset_dev.h

GNSS SUBSYSTEM
M: Johan Hovold <johan@kernel.org>
T: git git://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss.git
S: Maintained
F: Documentation/ABI/testing/sysfs-class-gnss
F: Documentation/devicetree/bindings/gnss/
Expand Down
6 changes: 3 additions & 3 deletions drivers/gnss/sirf.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ static int sirf_set_active(struct sirf_data *data, bool active)
else
timeout = SIRF_HIBERNATE_TIMEOUT;

while (retries-- > 0) {
do {
sirf_pulse_on_off(data);
ret = sirf_wait_for_power_state(data, active, timeout);
if (ret < 0) {
Expand All @@ -179,9 +179,9 @@ static int sirf_set_active(struct sirf_data *data, bool active)
}

break;
}
} while (retries--);

if (retries == 0)
if (retries < 0)
return -ETIMEDOUT;

return 0;
Expand Down

0 comments on commit dbde117

Please sign in to comment.