Skip to content

Commit

Permalink
iwlwifi: dbg_ini: use different barker for ini dump
Browse files Browse the repository at this point in the history
Use a different barker for ini dump to allow differentiation from legacy
dump. Also it allows to remove INI_BIT from dump TLVs.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
  • Loading branch information
Shahar S Matityahu authored and Luca Coelho committed Jun 29, 2019
1 parent c7ab138 commit dc14b80
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
4 changes: 2 additions & 2 deletions drivers/net/wireless/intel/iwlwifi/fw/dbg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1690,7 +1690,7 @@ iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt,

num_of_ranges = ops->get_num_of_ranges(fwrt, reg);

(*data)->type = cpu_to_le32(type | INI_DUMP_BIT);
(*data)->type = cpu_to_le32(type);
(*data)->len = cpu_to_le32(size);

header->region_id = reg->region_id;
Expand Down Expand Up @@ -1935,7 +1935,7 @@ iwl_fw_error_ini_dump_file(struct iwl_fw_runtime *fwrt,
if (!dump_file)
return NULL;

dump_file->barker = cpu_to_le32(IWL_FW_ERROR_DUMP_BARKER);
dump_file->barker = cpu_to_le32(IWL_FW_INI_ERROR_DUMP_BARKER);
dump_data = (void *)dump_file->data;
dump_file->file_len = cpu_to_le32(size);

Expand Down
4 changes: 1 addition & 3 deletions drivers/net/wireless/intel/iwlwifi/fw/error-dump.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
#include <linux/types.h>

#define IWL_FW_ERROR_DUMP_BARKER 0x14789632
#define IWL_FW_INI_ERROR_DUMP_BARKER 0x14789633

/**
* enum iwl_fw_error_dump_type - types of data in the dump file
Expand Down Expand Up @@ -283,9 +284,6 @@ struct iwl_fw_error_dump_mem {
*/
#define IWL_INI_DUMP_VER 1

/* This bit is used to differentiate the legacy dump from the ini dump */
#define INI_DUMP_BIT BIT(31)

/**
* struct iwl_fw_ini_fifo_hdr - fifo range header
* @fifo_num: the fifo number. In case of umac rx fifo, set BIT(31) to
Expand Down

0 comments on commit dc14b80

Please sign in to comment.