Skip to content

Commit

Permalink
arm64: dts: imx8m: fix aips dts node
Browse files Browse the repository at this point in the history
Per binding doc fsl,aips-bus.yaml, compatible and reg is
required. And for reg, the AIPS configuration space should be
used, not all the AIPS bus space.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
  • Loading branch information
Peng Fan authored and Shawn Guo committed Mar 16, 2020
1 parent 819779a commit dc3efc6
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 22 deletions.
12 changes: 8 additions & 4 deletions arch/arm64/boot/dts/freescale/imx8mm.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@
ranges = <0x0 0x0 0x0 0x3e000000>;

aips1: bus@30000000 {
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x301f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30000000 0x30000000 0x400000>;
Expand Down Expand Up @@ -541,7 +542,8 @@
};

aips2: bus@30400000 {
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x305f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30400000 0x30400000 0x400000>;
Expand Down Expand Up @@ -600,7 +602,8 @@
};

aips3: bus@30800000 {
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x309f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30800000 0x30800000 0x400000>,
Expand Down Expand Up @@ -859,7 +862,8 @@
};

aips4: bus@32c00000 {
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32df0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x32c00000 0x32c00000 0x400000>;
Expand Down
16 changes: 8 additions & 8 deletions arch/arm64/boot/dts/freescale/imx8mn.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@
ranges = <0x0 0x0 0x0 0x3e000000>;

aips1: bus@30000000 {
compatible = "simple-bus";
reg = <0x30000000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x301f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down Expand Up @@ -445,8 +445,8 @@
};

aips2: bus@30400000 {
compatible = "simple-bus";
reg = <0x30400000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x305f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down Expand Up @@ -505,8 +505,8 @@
};

aips3: bus@30800000 {
compatible = "simple-bus";
reg = <0x30800000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x309f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down Expand Up @@ -751,8 +751,8 @@
};

aips4: bus@32c00000 {
compatible = "simple-bus";
reg = <0x32c00000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32df0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down
12 changes: 6 additions & 6 deletions arch/arm64/boot/dts/freescale/imx8mp.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@
ranges = <0x0 0x0 0x0 0x3e000000>;

aips1: bus@30000000 {
compatible = "simple-bus";
reg = <0x30000000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x301f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down Expand Up @@ -315,8 +315,8 @@
};

aips2: bus@30400000 {
compatible = "simple-bus";
reg = <0x30400000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x305f0000 0x400000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down Expand Up @@ -375,8 +375,8 @@
};

aips3: bus@30800000 {
compatible = "simple-bus";
reg = <0x30800000 0x400000>;
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x309f0000 0x400000>;
#address-cells = <1>;
#size-cells = <1>;
ranges;
Expand Down
12 changes: 8 additions & 4 deletions arch/arm64/boot/dts/freescale/imx8mq.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,8 @@
dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>;

bus@30000000 { /* AIPS1 */
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x301f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30000000 0x30000000 0x400000>;
Expand Down Expand Up @@ -694,7 +695,8 @@
};

bus@30400000 { /* AIPS2 */
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x305f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30400000 0x30400000 0x400000>;
Expand Down Expand Up @@ -753,7 +755,8 @@
};

bus@30800000 { /* AIPS3 */
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x309f0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x30800000 0x30800000 0x400000>,
Expand Down Expand Up @@ -1025,7 +1028,8 @@
};

bus@32c00000 { /* AIPS4 */
compatible = "simple-bus";
compatible = "fsl,aips-bus", "simple-bus";
reg = <0x32df0000 0x10000>;
#address-cells = <1>;
#size-cells = <1>;
ranges = <0x32c00000 0x32c00000 0x400000>;
Expand Down

0 comments on commit dc3efc6

Please sign in to comment.