Skip to content

Commit

Permalink
Merge branch 'acpi-scan-fixes'
Browse files Browse the repository at this point in the history
* acpi-scan-fixes:
  ACPI / scan: Prefer devices without _HID for _ADR matching
  • Loading branch information
Rafael J. Wysocki committed Apr 7, 2017
2 parents a71c9a1 + fdad4e7 commit dc752d5
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/acpi/glue.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@ static int find_child_checks(struct acpi_device *adev, bool check_children)
return -ENODEV;

/*
* If the device has a _HID (or _CID) returning a valid ACPI/PNP
* device ID, it is better to make it look less attractive here, so that
* the other device with the same _ADR value (that may not have a valid
* device ID) can be matched going forward. [This means a second spec
* violation in a row, so whatever we do here is best effort anyway.]
* If the device has a _HID returning a valid ACPI/PNP device ID, it is
* better to make it look less attractive here, so that the other device
* with the same _ADR value (that may not have a valid device ID) can be
* matched going forward. [This means a second spec violation in a row,
* so whatever we do here is best effort anyway.]
*/
return sta_present && list_empty(&adev->pnp.ids) ?
return sta_present && !adev->pnp.type.platform_id ?
FIND_CHILD_MAX_SCORE : FIND_CHILD_MIN_SCORE;
}

Expand Down

0 comments on commit dc752d5

Please sign in to comment.