Skip to content

Commit

Permalink
drm/msm/mdss: use boolean values for macrotile_mode
Browse files Browse the repository at this point in the history
The macrotile_mode is a flag, not a bit value. Use true/false values to
set it rather than 1/0.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/626374/
Link: https://lore.kernel.org/r/20241127-msm-mdss-ubwc-v3-3-9782a7c2b023@linaro.org
  • Loading branch information
Dmitry Baryshkov committed Dec 15, 2024
1 parent 2cb62d9 commit dc7b16a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions drivers/gpu/drm/msm/msm_mdss.c
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ static const struct msm_mdss_data sa8775p_data = {
.ubwc_swizzle = 4,
.ubwc_bank_spread = true,
.highest_bank_bit = 0,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 74000,
};

Expand All @@ -607,15 +607,15 @@ static const struct msm_mdss_data sc7280_data = {
.ubwc_swizzle = 6,
.ubwc_bank_spread = true,
.highest_bank_bit = 1,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 74000,
};

static const struct msm_mdss_data sc8180x_data = {
.ubwc_enc_version = UBWC_3_0,
.ubwc_dec_version = UBWC_3_0,
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 76800,
};

Expand All @@ -625,7 +625,7 @@ static const struct msm_mdss_data sc8280xp_data = {
.ubwc_swizzle = 6,
.ubwc_bank_spread = true,
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 76800,
};

Expand Down Expand Up @@ -689,7 +689,7 @@ static const struct msm_mdss_data sm8250_data = {
.ubwc_bank_spread = true,
/* TODO: highest_bank_bit = 2 for LP_DDR4 */
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 76800,
};

Expand All @@ -700,7 +700,7 @@ static const struct msm_mdss_data sm8350_data = {
.ubwc_bank_spread = true,
/* TODO: highest_bank_bit = 2 for LP_DDR4 */
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 74000,
};

Expand All @@ -711,7 +711,7 @@ static const struct msm_mdss_data sm8550_data = {
.ubwc_bank_spread = true,
/* TODO: highest_bank_bit = 2 for LP_DDR4 */
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
.reg_bus_bw = 57000,
};

Expand All @@ -722,7 +722,7 @@ static const struct msm_mdss_data x1e80100_data = {
.ubwc_bank_spread = true,
/* TODO: highest_bank_bit = 2 for LP_DDR4 */
.highest_bank_bit = 3,
.macrotile_mode = 1,
.macrotile_mode = true,
/* TODO: Add reg_bus_bw with real value */
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/msm/msm_mdss.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ struct msm_mdss_data {
u32 ubwc_swizzle;
u32 highest_bank_bit;
bool ubwc_bank_spread;
u32 macrotile_mode;
bool macrotile_mode;
u32 reg_bus_bw;
};

Expand Down

0 comments on commit dc7b16a

Please sign in to comment.