Skip to content

Commit

Permalink
ASoC: rockchip: Remove unnecessary function call
Browse files Browse the repository at this point in the history
First of all,the address of pdev->dev is assigned to card->dev,then
the function platform_set_drvdata copies the value the variable card
to pdev->dev.driver_data, but when calling snd_soc_register_card,the
function dev_set_drvdata(card->dev, card) will also do the same copy
operation,so i think that the former copy operation can be removed.

Signed-off-by: Peng Donglin <dolinux.peng@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Donglin Peng authored and Mark Brown committed Aug 21, 2017
1 parent fce7358 commit dc94d24
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions sound/soc/rockchip/rk3288_hdmi_analog.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@ static int snd_rk_mc_probe(struct platform_device *pdev)
return ret;
}

platform_set_drvdata(pdev, card);

return ret;
}

Expand Down
1 change: 0 additions & 1 deletion sound/soc/rockchip/rk3399_gru_sound.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ static int rockchip_sound_probe(struct platform_device *pdev)
rockchip_dailinks[DAILINK_RT5514_DSP].platform_name = kstrdup_const(dev_name(dev), GFP_KERNEL);

card->dev = &pdev->dev;
platform_set_drvdata(pdev, card);

ret = devm_snd_soc_register_card(&pdev->dev, card);
if (ret)
Expand Down

0 comments on commit dc94d24

Please sign in to comment.