Skip to content

Commit

Permalink
x86/apic: Always define nox2apic and define it as initdata
Browse files Browse the repository at this point in the history
The "nox2apic" variable can be defined as __initdata since it is
only used for bootstrap.  It can now unconditionally be defined
since it will later be freed.

At the same time, it is also better off as a bool.

Signed-off-by: David Rientjes <rientjes@google.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1402042354380.7839@chino.kir.corp.google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
David Rientjes authored and Ingo Molnar committed Feb 9, 2014
1 parent 6d49898 commit dc9788f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 0 additions & 1 deletion arch/x86/include/asm/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,6 @@ static inline void x2apic_force_phys(void)
{
}

#define nox2apic 0
#define x2apic_preenabled 0
#define x2apic_supported() 0
#endif
Expand Down
9 changes: 6 additions & 3 deletions arch/x86/kernel/apic/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ static inline void imcr_apic_to_pic(void)
* +1=force-enable
*/
static int force_enable_local_apic __initdata;

/* Control whether x2APIC mode is enabled or not */
static bool nox2apic __initdata;

/*
* APIC command line parameters
*/
Expand Down Expand Up @@ -162,8 +166,7 @@ int x2apic_mode;
/* x2apic enabled before OS handover */
int x2apic_preenabled;
static int x2apic_disabled;
static int nox2apic;
static __init int setup_nox2apic(char *str)
static int __init setup_nox2apic(char *str)
{
if (x2apic_enabled()) {
int apicid = native_apic_msr_read(APIC_ID);
Expand All @@ -178,7 +181,7 @@ static __init int setup_nox2apic(char *str)
} else
setup_clear_cpu_cap(X86_FEATURE_X2APIC);

nox2apic = 1;
nox2apic = true;

return 0;
}
Expand Down

0 comments on commit dc9788f

Please sign in to comment.