Skip to content

Commit

Permalink
net/9p: Fix a potential socket leak in p9_socket_open
Browse files Browse the repository at this point in the history
Both p9_fd_create_tcp() and p9_fd_create_unix() will call
p9_socket_open(). If the creation of p9_trans_fd fails,
p9_fd_create_tcp() and p9_fd_create_unix() will return an
error directly instead of releasing the cscoket, which will
result in a socket leak.

This patch adds sock_release() to fix the leak issue.

Fixes: 6b18662 ("9p connect fixes")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
ACKed-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wang Hai authored and David S. Miller committed Nov 28, 2022
1 parent b8f79dc commit dcc14cf
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/9p/trans_fd.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,8 +860,10 @@ static int p9_socket_open(struct p9_client *client, struct socket *csocket)
struct file *file;

p = kzalloc(sizeof(struct p9_trans_fd), GFP_KERNEL);
if (!p)
if (!p) {
sock_release(csocket);
return -ENOMEM;
}

csocket->sk->sk_allocation = GFP_NOIO;
file = sock_alloc_file(csocket, 0, NULL);
Expand Down

0 comments on commit dcc14cf

Please sign in to comment.