Skip to content

Commit

Permalink
[IPV4]: Fix memory leak on error path during FIB initialization.
Browse files Browse the repository at this point in the history
net->ipv4.fib_table_hash is not freed when fib4_rules_init failed.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Denis V. Lunev authored and David S. Miller committed Feb 1, 2008
1 parent 3ed5df4 commit dce5cbe
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion net/ipv4/fib_frontend.c
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,7 @@ static struct notifier_block fib_netdev_notifier = {

static int __net_init ip_fib_net_init(struct net *net)
{
int err;
unsigned int i;

net->ipv4.fib_table_hash = kzalloc(
Expand All @@ -985,7 +986,14 @@ static int __net_init ip_fib_net_init(struct net *net)
for (i = 0; i < FIB_TABLE_HASHSZ; i++)
INIT_HLIST_HEAD(&net->ipv4.fib_table_hash[i]);

return fib4_rules_init(net);
err = fib4_rules_init(net);
if (err < 0)
goto fail;
return 0;

fail:
kfree(net->ipv4.fib_table_hash);
return err;
}

static void __net_exit ip_fib_net_exit(struct net *net)
Expand Down

0 comments on commit dce5cbe

Please sign in to comment.