Skip to content

Commit

Permalink
leds: Fix sparse warnings in leds-h1940 driver
Browse files Browse the repository at this point in the history
Fixes the following sparse errors:
drivers/leds/leds-h1940.c:26:6: warning: symbol 'h1940_greenled_set' was not declared. Should it be static?
drivers/leds/leds-h1940.c:55:6: warning: symbol 'h1940_redled_set' was not declared. Should it be static?
drivers/leds/leds-h1940.c:85:6: warning: symbol 'h1940_blueled_set' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
  • Loading branch information
Ben Dooks authored and Richard Purdie committed Jul 23, 2008
1 parent 781a54e commit dd1160d
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/leds/leds-h1940.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
/*
* Green led.
*/
void h1940_greenled_set(struct led_classdev *led_dev, enum led_brightness value)
static void h1940_greenled_set(struct led_classdev *led_dev,
enum led_brightness value)
{
switch (value) {
case LED_HALF:
Expand Down Expand Up @@ -52,7 +53,8 @@ static struct led_classdev h1940_greenled = {
/*
* Red led.
*/
void h1940_redled_set(struct led_classdev *led_dev, enum led_brightness value)
static void h1940_redled_set(struct led_classdev *led_dev,
enum led_brightness value)
{
switch (value) {
case LED_HALF:
Expand Down Expand Up @@ -82,7 +84,8 @@ static struct led_classdev h1940_redled = {
* Blue led.
* (it can only be blue flashing led)
*/
void h1940_blueled_set(struct led_classdev *led_dev, enum led_brightness value)
static void h1940_blueled_set(struct led_classdev *led_dev,
enum led_brightness value)
{
if (value) {
/* flashing Blue */
Expand Down

0 comments on commit dd1160d

Please sign in to comment.