Skip to content

Commit

Permalink
clk: keystone: syscon-clk: Fix audio refclk
Browse files Browse the repository at this point in the history
Audio REFCLK's are not working correctly, trying to use them lead to the
following errors:

[    6.575277] of_clk_hw_onecell_get: invalid index 4294934528
[    6.581515] wm8904 1-001a: Failed to get MCLK
[    6.586290] wm8904: probe of 1-001a failed with error -2

The issue is that Audio REFCLK has #clock-cells = 0 [1], while the driver
is registering those clocks assuming they have one cells. Fix this by
registering the clock with of_clk_hw_simple_get() when there is only one
instance, e.g. "audio_refclk".

[1] Documentation/devicetree/bindings/clock/ti,am62-audio-refclk.yaml

Fixes: 6acab96 ("clk: keystone: syscon-clk: Add support for audio refclk")
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Link: https://lore.kernel.org/r/20230728222639.110409-1-francesco@dolcini.it
[sboyd@kernel.org: Simplify if-return-else logic]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
  • Loading branch information
Francesco Dolcini authored and Stephen Boyd committed Aug 5, 2023
1 parent ae9b145 commit dd1df82
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/clk/keystone/syscon-clk.c
Original file line number Diff line number Diff line change
@@ -151,8 +151,10 @@ static int ti_syscon_gate_clk_probe(struct platform_device *pdev)
data[i].name);
}

return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
hw_data);
if (num_clks == 1)
return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
hw_data->hws[0]);
return devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, hw_data);
}

#define TI_SYSCON_CLK_GATE(_name, _offset, _bit_idx) \

0 comments on commit dd1df82

Please sign in to comment.