Skip to content

Commit

Permalink
Input: soc_button_array - properly map usage 0x07/0xe3 to KEY_LEFTMETA
Browse files Browse the repository at this point in the history
When submitting the support for the ACPI0011 windows tablet keys device I
mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is inconsistent
with how it is done on windows tablets using the old PNP0C40 ACPI device
and it does not match the HUT spec, which says that usage-page 7 usage 0xe3
is "Keyboard Left GUI".

This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.

Fixes: 4c3362f ("Input: soc_button_array - add support for ACPI 6.0...")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Hans de Goede authored and Dmitry Torokhov committed Apr 11, 2017
1 parent deeb1e9 commit dd22408
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/input/misc/soc_button_array.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
info->wakeup = true;
} else if (upage == 0x07 && usage == 0xe3) {
info->name = "home";
info->event_code = KEY_HOMEPAGE;
info->event_code = KEY_LEFTMETA;
info->wakeup = true;
} else if (upage == 0x0c && usage == 0xe9) {
info->name = "volume_up";
Expand Down

0 comments on commit dd22408

Please sign in to comment.