Skip to content

Commit

Permalink
KVM: x86: warn on incorrectly NULL members of kvm_x86_ops
Browse files Browse the repository at this point in the history
Use the newly corrected KVM_X86_OP annotations to warn about possible
NULL pointer dereferences as soon as the vendor module is loaded.

Reviewed-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
  • Loading branch information
Paolo Bonzini committed Feb 18, 2022
1 parent e4fc23b commit dd2319c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions arch/x86/include/asm/kvm_host.h
Original file line number Diff line number Diff line change
Expand Up @@ -1545,10 +1545,13 @@ extern struct kvm_x86_ops kvm_x86_ops;

static inline void kvm_ops_static_call_update(void)
{
#define KVM_X86_OP(func) \
#define __KVM_X86_OP(func) \
static_call_update(kvm_x86_##func, kvm_x86_ops.func);
#define KVM_X86_OP_OPTIONAL KVM_X86_OP
#define KVM_X86_OP(func) \
WARN_ON(!kvm_x86_ops.func); __KVM_X86_OP(func)
#define KVM_X86_OP_OPTIONAL __KVM_X86_OP
#include <asm/kvm-x86-ops.h>
#undef __KVM_X86_OP
}

#define __KVM_HAVE_ARCH_VM_ALLOC
Expand Down

0 comments on commit dd2319c

Please sign in to comment.