Skip to content

Commit

Permalink
scripts: recordmcount: break hardlinks
Browse files Browse the repository at this point in the history
recordmcount edits the file in-place, which can cause problems when
using ccache in hardlink mode.  Arrange for recordmcount to break a
hardlinked object.

Link: http://lkml.kernel.org/r/E1a7MVT-0000et-62@rmk-PC.arm.linux.org.uk

Cc: stable@vger.kernel.org # 2.6.37+
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Russell King authored and Steven Rostedt committed Dec 16, 2015
1 parent 9f9499a commit dd39a26
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions scripts/recordmcount.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,20 @@ static void *mmap_file(char const *fname)
addr = umalloc(sb.st_size);
uread(fd_map, addr, sb.st_size);
}
if (sb.st_nlink != 1) {
/* file is hard-linked, break the hard link */
close(fd_map);
if (unlink(fname) < 0) {
perror(fname);
fail_file();
}
fd_map = open(fname, O_RDWR | O_CREAT, sb.st_mode);
if (fd_map < 0) {
perror(fname);
fail_file();
}
uwrite(fd_map, addr, sb.st_size);
}
return addr;
}

Expand Down

0 comments on commit dd39a26

Please sign in to comment.