Skip to content

Commit

Permalink
ext4: fix up ext4 error handling
Browse files Browse the repository at this point in the history
Make sure we the correct cleanup happens if we die while trying to
load the ext4 file system.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Feb 3, 2011
1 parent 8f02122 commit dd68314
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions fs/ext4/super.c
Original file line number Diff line number Diff line change
@@ -4810,13 +4810,17 @@ static int __init ext4_init_fs(void)
return err;
err = ext4_init_system_zone();
if (err)
goto out5;
goto out7;
ext4_kset = kset_create_and_add("ext4", NULL, fs_kobj);
if (!ext4_kset)
goto out4;
goto out6;
ext4_proc_root = proc_mkdir("fs/ext4", NULL);
if (!ext4_proc_root)
goto out5;

err = ext4_init_feat_adverts();
if (err)
goto out4;

err = ext4_init_mballoc();
if (err)
@@ -4847,11 +4851,13 @@ static int __init ext4_init_fs(void)
ext4_exit_mballoc();
out3:
ext4_exit_feat_adverts();
out4:
remove_proc_entry("fs/ext4", NULL);
out5:
kset_unregister(ext4_kset);
out4:
out6:
ext4_exit_system_zone();
out5:
out7:
ext4_exit_pageio();
return err;
}

0 comments on commit dd68314

Please sign in to comment.