Skip to content

Commit

Permalink
dm cache metadata: return bool from __superblock_all_zeroes
Browse files Browse the repository at this point in the history 
Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Joe Thornber authored and Mike Snitzer committed Nov 9, 2013
1 parent 0184b44 commit dd8b0c2
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/md/dm-cache-metadata.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ static int superblock_lock(struct dm_cache_metadata *cmd,

/*----------------------------------------------------------------*/

static int __superblock_all_zeroes(struct dm_block_manager *bm, int *result)
static int __superblock_all_zeroes(struct dm_block_manager *bm, bool *result)
{
int r;
unsigned i;
Expand All @@ -214,10 +214,10 @@ static int __superblock_all_zeroes(struct dm_block_manager *bm, int *result)
return r;

data_le = dm_block_data(b);
*result = 1;
*result = true;
for (i = 0; i < sb_block_size; i++) {
if (data_le[i] != zero) {
*result = 0;
*result = false;
break;
}
}
Expand Down Expand Up @@ -411,7 +411,8 @@ static int __open_metadata(struct dm_cache_metadata *cmd)
static int __open_or_format_metadata(struct dm_cache_metadata *cmd,
bool format_device)
{
int r, unformatted;
int r;
bool unformatted = false;

r = __superblock_all_zeroes(cmd->bm, &unformatted);
if (r)
Expand Down

0 comments on commit dd8b0c2

Please sign in to comment.