Skip to content

Commit

Permalink
qla2xxx: fix crash due to task mgmt cmd type
Browse files Browse the repository at this point in the history
tcm_qla2xxx_get_task_tag incorrectly assume command is
qla_tgt_cmd.  Add check to see if it's a scsi cmd or
task mgmt command.

Signed-off-by: Quinn Tran <quinn.tran@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
  • Loading branch information
Himanshu Madhani authored and Christoph Hellwig committed Sep 25, 2014
1 parent d29fb73 commit dd9c4ef
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/scsi/qla2xxx/tcm_qla2xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,13 @@ static void tcm_qla2xxx_set_default_node_attrs(struct se_node_acl *nacl)

static u32 tcm_qla2xxx_get_task_tag(struct se_cmd *se_cmd)
{
struct qla_tgt_cmd *cmd = container_of(se_cmd,
struct qla_tgt_cmd, se_cmd);
struct qla_tgt_cmd *cmd;

/* check for task mgmt cmd */
if (se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)
return 0xffffffff;

cmd = container_of(se_cmd, struct qla_tgt_cmd, se_cmd);

return cmd->tag;
}
Expand Down

0 comments on commit dd9c4ef

Please sign in to comment.