Skip to content

Commit

Permalink
HID: usbhid: change return error of usbhid_output_report
Browse files Browse the repository at this point in the history
If there is no urbout when sending a output report, ENOSYS (Function
not implemented) is a better error than EIO (I/O error).

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Benjamin Tissoires authored and Jiri Kosina committed Feb 17, 2014
1 parent 649f947 commit ddea1af
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/usbhid/hid-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ static int usbhid_output_report(struct hid_device *hid, __u8 *buf, size_t count)
int actual_length, skipped_report_id = 0, ret;

if (!usbhid->urbout)
return -EIO;
return -ENOSYS;

if (buf[0] == 0x0) {
/* Don't send the Report ID */
Expand Down

0 comments on commit ddea1af

Please sign in to comment.