Skip to content

Commit

Permalink
Input: adi - remove an unnecessary check
Browse files Browse the repository at this point in the history
The input_free_device() function tests whether its argument is NULL and
then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
  • Loading branch information
Markus Elfring authored and Dmitry Torokhov committed Feb 12, 2015
1 parent 2b2f514 commit de3748f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/input/joystick/adi.c
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,7 @@ static int adi_connect(struct gameport *gameport, struct gameport_driver *drv)
}
}
fail2: for (i = 0; i < 2; i++)
if (port->adi[i].dev)
input_free_device(port->adi[i].dev);
input_free_device(port->adi[i].dev);
gameport_close(gameport);
fail1: gameport_set_drvdata(gameport, NULL);
kfree(port);
Expand Down

0 comments on commit de3748f

Please sign in to comment.