Skip to content

Commit

Permalink
selftests: drv-net: rss_ctx: add missing cleanup in queue reconfigure
Browse files Browse the repository at this point in the history
Commit under Fixes adds ntuple rules but never deletes them.

Fixes: 29a4bc1 ("selftest: extend test_rss_context_queue_reconfigure for action addition")
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250201013040.725123-4-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed Feb 4, 2025
1 parent 2b91cc1 commit de379df
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/testing/selftests/drivers/net/hw/rss_ctx.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True):
try:
# this targets queue 4, which doesn't exist
ntuple2 = ethtool_create(cfg, "-N", flow)
defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")
except CmdExitFailure:
pass
else:
Expand All @@ -260,6 +261,7 @@ def test_rss_queue_reconfigure(cfg, main_ctx=True):
ethtool(f"-X {cfg.ifname} {ctx_ref} weight 1 0 1 0")
# ntuple rule therefore targets queues 1 and 3
ntuple2 = ethtool_create(cfg, "-N", flow)
defer(ethtool, f"-N {cfg.ifname} delete {ntuple2}")
# should replace existing filter
ksft_eq(ntuple, ntuple2)
_send_traffic_check(cfg, port, ctx_ref, { 'target': (1, 3),
Expand Down

0 comments on commit de379df

Please sign in to comment.