Skip to content

Commit

Permalink
drm/amd/display: Add Freesync Panel DM code
Browse files Browse the repository at this point in the history
We need certain conditions for replay to be enabled, so create an
interface in DM to enable/disable replay.

Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Bhawanpreet Lakha authored and Alex Deucher committed Aug 7, 2023
1 parent ae77d2f commit dede1fe
Show file tree
Hide file tree
Showing 7 changed files with 237 additions and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/display/amdgpu_dm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ AMDGPUDM += dc_fpu.o
endif

ifneq ($(CONFIG_DRM_AMD_DC),)
AMDGPUDM += amdgpu_dm_services.o amdgpu_dm_helpers.o amdgpu_dm_pp_smu.o amdgpu_dm_psr.o
AMDGPUDM += amdgpu_dm_services.o amdgpu_dm_helpers.o amdgpu_dm_pp_smu.o amdgpu_dm_psr.o amdgpu_dm_replay.o
endif

AMDGPUDM += amdgpu_dm_hdcp.o
Expand Down
176 changes: 176 additions & 0 deletions drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
/*
* Copyright 2023 Advanced Micro Devices, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* Authors: AMD
*
*/

#include "amdgpu_dm_replay.h"
#include "dc.h"
#include "dm_helpers.h"
#include "amdgpu_dm.h"
#include "modules/power/power_helpers.h"
#include "dmub/inc/dmub_cmd.h"
#include "dc/inc/link.h"

/*
* link_supports_replay() - check if the link supports replay
* @link: link
* @aconnector: aconnector
*
*/
static bool link_supports_replay(struct dc_link *link, struct amdgpu_dm_connector *aconnector)
{
struct dm_connector_state *state = to_dm_connector_state(aconnector->base.state);
struct dpcd_caps *dpcd_caps = &link->dpcd_caps;
struct adaptive_sync_caps *as_caps = &link->dpcd_caps.adaptive_sync_caps;

if (!state->freesync_capable)
return false;

// Check the eDP version
if (dpcd_caps->edp_rev < EDP_REVISION_13)
return false;

if (!dpcd_caps->alpm_caps.bits.AUX_WAKE_ALPM_CAP)
return false;

// Check adaptive sync support cap
if (!as_caps->dp_adap_sync_caps.bits.ADAPTIVE_SYNC_SDP_SUPPORT)
return false;

return true;
}

/*
* amdgpu_dm_setup_replay() - setup replay configuration
* @link: link
* @aconnector: aconnector
*
*/
bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *aconnector)
{
struct replay_config pr_config;
union replay_debug_flags *debug_flags = NULL;

if (!dc_is_embedded_signal(link->connector_signal))
return false;

if (link->panel_config.psr.disallow_replay)
return false;

if (!link_supports_replay(link, aconnector))
return false;

// Mark Replay is supported in link and update related attributes
pr_config.replay_supported = true;
pr_config.replay_power_opt_supported = 0;
pr_config.replay_enable_option |= pr_enable_option_static_screen;
pr_config.replay_timing_sync_supported = aconnector->max_vfreq >= 2 * aconnector->min_vfreq ? true : false;

if (!pr_config.replay_timing_sync_supported)
pr_config.replay_enable_option &= ~pr_enable_option_general_ui;

debug_flags = (union replay_debug_flags *)&pr_config.debug_flags;
debug_flags->u32All = 0;
debug_flags->bitfields.visual_confirm =
link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY ? true : false;

link->replay_settings.replay_feature_enabled = true;

init_replay_config(link, &pr_config);

return true;
}


/*
* amdgpu_dm_replay_enable() - enable replay f/w
* @stream: stream state
*
* Return: true if success
*/
bool amdgpu_dm_replay_enable(struct dc_stream_state *stream, bool wait)
{
uint64_t state;
unsigned int retry_count;
bool replay_active = true;
const unsigned int max_retry = 1000;
bool force_static = true;
struct dc_link *link = NULL;


if (stream == NULL)
return false;

link = stream->link;

if (link == NULL)
return false;

link->dc->link_srv->edp_setup_replay(link, stream);

link->dc->link_srv->edp_set_replay_allow_active(link, NULL, false, false, NULL);

link->dc->link_srv->edp_set_replay_allow_active(link, &replay_active, false, true, NULL);

if (wait == true) {

for (retry_count = 0; retry_count <= max_retry; retry_count++) {
dc_link_get_replay_state(link, &state);
if (replay_active) {
if (state != REPLAY_STATE_0 &&
(!force_static || state == REPLAY_STATE_3))
break;
} else {
if (state == REPLAY_STATE_0)
break;
}
udelay(500);
}

/* assert if max retry hit */
if (retry_count >= max_retry)
ASSERT(0);
} else {
/* To-do: Add trace log */
}

return true;
}

/*
* amdgpu_dm_replay_disable() - disable replay f/w
* @stream: stream state
*
* Return: true if success
*/
bool amdgpu_dm_replay_disable(struct dc_stream_state *stream)
{

if (stream->link) {
DRM_DEBUG_DRIVER("Disabling replay...\n");
stream->link->dc->link_srv->edp_set_replay_allow_active(stream->link, NULL, false, false, NULL);
return true;
}

return false;
}
46 changes: 46 additions & 0 deletions drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/*
* Copyright 2021 Advanced Micro Devices, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*
* Authors: AMD
*
*/

#ifndef AMDGPU_DM_AMDGPU_DM_REPLAY_H_
#define AMDGPU_DM_AMDGPU_DM_REPLAY_H_

#include "amdgpu.h"

enum replay_enable_option {
pr_enable_option_static_screen = 0x1,
pr_enable_option_mpo_video = 0x2,
pr_enable_option_full_screen_video = 0x4,
pr_enable_option_general_ui = 0x8,
pr_enable_option_static_screen_coasting = 0x10000,
pr_enable_option_mpo_video_coasting = 0x20000,
pr_enable_option_full_screen_video_coasting = 0x40000,
};


bool amdgpu_dm_replay_enable(struct dc_stream_state *stream, bool enable);
bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *aconnector);
bool amdgpu_dm_replay_disable(struct dc_stream_state *stream);

#endif /* AMDGPU_DM_AMDGPU_DM_REPLAY_H_ */
5 changes: 5 additions & 0 deletions drivers/gpu/drm/amd/display/dc/core/dc_link_exports.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,11 @@ bool dc_link_setup_psr(struct dc_link *link,
return link->dc->link_srv->edp_setup_psr(link, stream, psr_config, psr_context);
}

bool dc_link_get_replay_state(const struct dc_link *link, uint64_t *state)
{
return link->dc->link_srv->edp_get_replay_state(link, state);
}

bool dc_link_wait_for_t12(struct dc_link *link)
{
return link->dc->link_srv->edp_wait_for_t12(link);
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/amd/display/dc/dc.h
Original file line number Diff line number Diff line change
Expand Up @@ -2011,6 +2011,8 @@ bool dc_link_setup_psr(struct dc_link *dc_link,
const struct dc_stream_state *stream, struct psr_config *psr_config,
struct psr_context *psr_context);

bool dc_link_get_replay_state(const struct dc_link *dc_link, uint64_t *state);

/* On eDP links this function call will stall until T12 has elapsed.
* If the panel is not in power off state, this function will return
* immediately.
Expand Down
5 changes: 5 additions & 0 deletions drivers/gpu/drm/amd/display/modules/power/power_helpers.c
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,11 @@ void mod_power_calc_psr_configs(struct psr_config *psr_config,
!link->dpcd_caps.psr_info.psr_dpcd_caps.bits.LINK_TRAINING_ON_EXIT_NOT_REQUIRED;
}

void init_replay_config(struct dc_link *link, struct replay_config *pr_config)
{
link->replay_settings.config = *pr_config;
}

bool mod_power_only_edp(const struct dc_state *context, const struct dc_stream_state *stream)
{
return context && context->stream_count == 1 && dc_is_embedded_signal(stream->signal);
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/amd/display/modules/power/power_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ bool dmub_init_abm_config(struct resource_pool *res_pool,
struct dmcu_iram_parameters params,
unsigned int inst);

void init_replay_config(struct dc_link *link, struct replay_config *pr_config);

bool is_psr_su_specific_panel(struct dc_link *link);
void mod_power_calc_psr_configs(struct psr_config *psr_config,
struct dc_link *link,
Expand Down

0 comments on commit dede1fe

Please sign in to comment.