Skip to content

Commit

Permalink
IB/iser: Remove unused "write-only" variables
Browse files Browse the repository at this point in the history
Remove variables that are set but then never looked at in the iSER
initiator.  These cleanups came from David Binderman's list of "set
but never used" warnings from icc.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Roland Dreier committed Dec 12, 2006
1 parent 44f8e3f commit dee234f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
4 changes: 0 additions & 4 deletions drivers/infiniband/ulp/iser/iser_initiator.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,8 @@ int iser_send_control(struct iscsi_conn *conn,
struct iscsi_iser_conn *iser_conn = conn->dd_data;
struct iser_desc *mdesc = mtask->dd_data;
struct iser_dto *send_dto = NULL;
unsigned int itt;
unsigned long data_seg_len;
int err = 0;
unsigned char opcode;
struct iser_regd_buf *regd_buf;
struct iser_device *device;

Expand All @@ -512,8 +510,6 @@ int iser_send_control(struct iscsi_conn *conn,

iser_reg_single(device, send_dto->regd[0], DMA_TO_DEVICE);

itt = ntohl(mtask->hdr->itt);
opcode = mtask->hdr->opcode & ISCSI_OPCODE_MASK;
data_seg_len = ntoh24(mtask->hdr->dlength);

if (data_seg_len > 0) {
Expand Down
3 changes: 1 addition & 2 deletions drivers/infiniband/ulp/iser/iser_memory.c
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ static int iser_sg_to_page_vec(struct iser_data_buf *data,
{
struct scatterlist *sg = (struct scatterlist *)data->buf;
dma_addr_t first_addr, last_addr, page;
int start_aligned, end_aligned;
int end_aligned;
unsigned int cur_page = 0;
unsigned long total_sz = 0;
int i;
Expand All @@ -249,7 +249,6 @@ static int iser_sg_to_page_vec(struct iser_data_buf *data,
first_addr = sg_dma_address(&sg[i]);
last_addr = first_addr + sg_dma_len(&sg[i]);

start_aligned = !(first_addr & ~MASK_4K);
end_aligned = !(last_addr & ~MASK_4K);

/* continue to collect page fragments till aligned or SG ends */
Expand Down

0 comments on commit dee234f

Please sign in to comment.