Skip to content

Commit

Permalink
kgdb: Move the extern declaration kgdb_has_hit_break() to generic kgdb.h
Browse files Browse the repository at this point in the history
Currently, only riscv kgdb.c uses the kgdb_has_hit_break() to identify
the kgdb breakpoint. It causes other architectures will encounter the "no
previous prototype" warnings if the compile option has W=1. Moving the
declaration of extern kgdb_has_hit_break() from risc-v kgdb.h to generic
kgdb.h to avoid generating these warnings.

Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
  • Loading branch information
Vincent Chen authored and Palmer Dabbelt committed Jul 10, 2020
1 parent f7fc752 commit def0aa2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion arch/riscv/include/asm/kgdb.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#ifndef __ASSEMBLY__

extern int kgdb_has_hit_break(unsigned long addr);
extern unsigned long kgdb_compiled_break;

static inline void arch_kgdb_breakpoint(void)
Expand Down
1 change: 1 addition & 0 deletions include/linux/kgdb.h
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ extern int kgdb_hex2mem(char *buf, char *mem, int count);

extern int kgdb_isremovedbreak(unsigned long addr);
extern void kgdb_schedule_breakpoint(void);
extern int kgdb_has_hit_break(unsigned long addr);

extern int
kgdb_handle_exception(int ex_vector, int signo, int err_code,
Expand Down

0 comments on commit def0aa2

Please sign in to comment.