Skip to content

Commit

Permalink
spi: mchp-pci1xxxx: release resources on error in probe()
Browse files Browse the repository at this point in the history
Call pci_release_regions(pdev) before returning on this error path.

Fixes: 3e7cfd6 ("spi: mchp-pci1xxxx: Add support for DMA in SPI")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://msgid.link/r/efc92197-4023-4bfe-bc63-452e7ed112e8@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Dan Carpenter authored and Mark Brown committed Feb 13, 2024
1 parent fc5b764 commit df20385
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/spi/spi-pci1xxxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id *

ret = pci1xxxx_spi_dma_init(spi_bus, spi_sub_ptr->irq);
if (ret && ret != -EOPNOTSUPP)
return ret;
goto error;

/* This register is only applicable for 1st instance */
regval = readl(spi_bus->reg_base + SPI_PCI_CTRL_REG_OFFSET(0));
Expand Down

0 comments on commit df20385

Please sign in to comment.