Skip to content

Commit

Permalink
scsi: Use 'depends' with LIBFC instead of 'select'.
Browse files Browse the repository at this point in the history
LIBFC depends upon SCSI_FC_ATTRS and select's CRC32C.

The only alternative would be to 'select' CRC32C and all of
SCSI_FC_ATTRS direct and indirect dependencies in the Kconfig section
for every LIBFCOE user which makes little sense.

Subsequently, use 'depends' instead of 'select' for LIBFCOE too.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Sep 22, 2014
1 parent afbe7af commit df568d8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions drivers/scsi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -592,21 +592,21 @@ config LIBFC

config LIBFCOE
tristate "LibFCoE module"
select LIBFC
depends on LIBFC
---help---
Library for Fibre Channel over Ethernet module

config FCOE
tristate "FCoE module"
depends on PCI
select LIBFCOE
depends on LIBFCOE
---help---
Fibre Channel over Ethernet module

config FCOE_FNIC
tristate "Cisco FNIC Driver"
depends on PCI && X86
select LIBFCOE
depends on LIBFCOE
help
This is support for the Cisco PCI-Express FCoE HBA.

Expand Down
4 changes: 2 additions & 2 deletions drivers/scsi/bnx2fc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ config SCSI_BNX2X_FCOE
tristate "QLogic NetXtreme II FCoE support"
depends on PCI
depends on (IPV6 || IPV6=n)
depends on LIBFC
depends on LIBFCOE
select NETDEVICES
select ETHERNET
select NET_VENDOR_BROADCOM
select LIBFC
select LIBFCOE
select CNIC
---help---
This driver supports FCoE offload for the QLogic NetXtreme II
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/qla2xxx/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ config SCSI_QLA_FC
config TCM_QLA2XXX
tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
depends on SCSI_QLA_FC && TARGET_CORE
select LIBFC
depends on LIBFC
select BTREE
default n
---help---
Expand Down

0 comments on commit df568d8

Please sign in to comment.