Skip to content

Commit

Permalink
powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
Browse files Browse the repository at this point in the history
of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: ce21b3c ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
  • Loading branch information
Miaoqian Lin authored and Michael Ellerman committed Aug 1, 2022
1 parent 255b650 commit df5d4b6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/powerpc/platforms/cell/axon_msi.c
Original file line number Diff line number Diff line change
@@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
if (!prop) {
dev_dbg(&dev->dev,
"axon_msi: no msi-address-(32|64) properties found\n");
of_node_put(dn);
return -ENOENT;
}

0 comments on commit df5d4b6

Please sign in to comment.