Skip to content

Commit

Permalink
Revert "drm/i915/display: Drop unnecessary frontbuffer flushes"
Browse files Browse the repository at this point in the history
This reverts commit 1c228ed.

Signed-off-by: Timo Aaltonen <timo.aaltonen@canonical.com>
  • Loading branch information
Timo Aaltonen committed Jun 27, 2022
1 parent 997dc86 commit df82026
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/display/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -2020,6 +2020,8 @@ intel_find_initial_plane_obj(struct intel_crtc *intel_crtc,
intel_plane_copy_uapi_to_hw_state(intel_state, intel_state,
intel_crtc);

intel_frontbuffer_flush(to_intel_frontbuffer(fb), ORIGIN_DIRTYFB);

atomic_or(to_intel_plane(primary)->frontbuffer_bit,
&to_intel_frontbuffer(fb)->bits);
}
Expand Down Expand Up @@ -11159,6 +11161,7 @@ intel_prepare_plane_fb(struct drm_plane *_plane,
return ret;

i915_gem_object_wait_priority(obj, 0, &attr);
i915_gem_object_flush_frontbuffer(obj, ORIGIN_DIRTYFB);

if (!new_plane_state->uapi.fence) { /* implicit fencing */
struct dma_fence *fence;
Expand Down
2 changes: 2 additions & 0 deletions drivers/gpu/drm/i915/display/intel_fbdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ static int intelfb_create(struct drm_fb_helper *helper,
goto out_unlock;
}

intel_frontbuffer_flush(to_frontbuffer(ifbdev), ORIGIN_DIRTYFB);

info = drm_fb_helper_alloc_fbi(helper);
if (IS_ERR(info)) {
drm_err(&dev_priv->drm, "Failed to allocate fb_info\n");
Expand Down

0 comments on commit df82026

Please sign in to comment.