Skip to content

Commit

Permalink
KVM: SVM: Refactor AVIC vcpu initialization into avic_init_vcpu()
Browse files Browse the repository at this point in the history
Preparing the base code for subsequent changes. This does not change
existing logic.

Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
  • Loading branch information
Suravee Suthikulpanit authored and Radim Krčmář committed Sep 13, 2017
1 parent 5153723 commit dfa2009
Showing 1 changed file with 20 additions and 8 deletions.
28 changes: 20 additions & 8 deletions arch/x86/kvm/svm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1600,6 +1600,23 @@ static void svm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
avic_update_vapic_bar(svm, APIC_DEFAULT_PHYS_BASE);
}

static int avic_init_vcpu(struct vcpu_svm *svm)
{
int ret;

if (!avic)
return 0;

ret = avic_init_backing_page(&svm->vcpu);
if (ret)
return ret;

INIT_LIST_HEAD(&svm->ir_list);
spin_lock_init(&svm->ir_list_lock);

return ret;
}

static struct kvm_vcpu *svm_create_vcpu(struct kvm *kvm, unsigned int id)
{
struct vcpu_svm *svm;
Expand Down Expand Up @@ -1636,14 +1653,9 @@ static struct kvm_vcpu *svm_create_vcpu(struct kvm *kvm, unsigned int id)
if (!hsave_page)
goto free_page3;

if (avic) {
err = avic_init_backing_page(&svm->vcpu);
if (err)
goto free_page4;

INIT_LIST_HEAD(&svm->ir_list);
spin_lock_init(&svm->ir_list_lock);
}
err = avic_init_vcpu(svm);
if (err)
goto free_page4;

/* We initialize this flag to true to make sure that the is_running
* bit would be set the first time the vcpu is loaded.
Expand Down

0 comments on commit dfa2009

Please sign in to comment.