Skip to content

Commit

Permalink
tools: ynl-gen: move local vars after the opening bracket
Browse files Browse the repository at this point in the history
The "function writing helper" tries to put local variables
between prototype and the opening bracket. Clearly wrong,
but up until now nothing actually uses it to write local
vars so it wasn't noticed.

Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250414211851.602096-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed Apr 17, 2025
1 parent 4d07bbf commit dfa464b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/net/ynl/pyynl/ynl_gen_c.py
Original file line number Diff line number Diff line change
Expand Up @@ -1399,9 +1399,9 @@ def write_func_lvar(self, local_vars):

def write_func(self, qual_ret, name, body, args=None, local_vars=None):
self.write_func_prot(qual_ret=qual_ret, name=name, args=args)
self.block_start()
self.write_func_lvar(local_vars=local_vars)

self.block_start()
for line in body:
self.p(line)
self.block_end()
Expand Down

0 comments on commit dfa464b

Please sign in to comment.