Skip to content

Commit

Permalink
PM: hibernate: Convert to bdev_open_by_dev()
Browse files Browse the repository at this point in the history
Convert hibernation code to use bdev_open_by_dev().

CC: linux-pm@vger.kernel.org
Acked-by: Christoph Hellwig <hch@lst.de>
Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
Acked-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230927093442.25915-16-jack@suse.cz
Signed-off-by: Christian Brauner <brauner@kernel.org>
  • Loading branch information
Jan Kara authored and Christian Brauner committed Oct 28, 2023
1 parent e6aafdc commit e017d30
Showing 1 changed file with 16 additions and 15 deletions.
31 changes: 16 additions & 15 deletions kernel/power/swap.c
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ int swsusp_swap_in_use(void)
*/

static unsigned short root_swap = 0xffff;
static struct block_device *hib_resume_bdev;
static struct bdev_handle *hib_resume_bdev_handle;

struct hib_bio_batch {
atomic_t count;
Expand Down Expand Up @@ -276,7 +276,8 @@ static int hib_submit_io(blk_opf_t opf, pgoff_t page_off, void *addr,
struct bio *bio;
int error = 0;

bio = bio_alloc(hib_resume_bdev, 1, opf, GFP_NOIO | __GFP_HIGH);
bio = bio_alloc(hib_resume_bdev_handle->bdev, 1, opf,
GFP_NOIO | __GFP_HIGH);
bio->bi_iter.bi_sector = page_off * (PAGE_SIZE >> 9);

if (bio_add_page(bio, page, PAGE_SIZE, 0) < PAGE_SIZE) {
Expand Down Expand Up @@ -356,14 +357,14 @@ static int swsusp_swap_check(void)
return res;
root_swap = res;

hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device,
hib_resume_bdev_handle = bdev_open_by_dev(swsusp_resume_device,
BLK_OPEN_WRITE, NULL, NULL);
if (IS_ERR(hib_resume_bdev))
return PTR_ERR(hib_resume_bdev);
if (IS_ERR(hib_resume_bdev_handle))
return PTR_ERR(hib_resume_bdev_handle);

res = set_blocksize(hib_resume_bdev, PAGE_SIZE);
res = set_blocksize(hib_resume_bdev_handle->bdev, PAGE_SIZE);
if (res < 0)
blkdev_put(hib_resume_bdev, NULL);
bdev_release(hib_resume_bdev_handle);

return res;
}
Expand Down Expand Up @@ -1522,10 +1523,10 @@ int swsusp_check(bool exclusive)
void *holder = exclusive ? &swsusp_holder : NULL;
int error;

hib_resume_bdev = blkdev_get_by_dev(swsusp_resume_device, BLK_OPEN_READ,
holder, NULL);
if (!IS_ERR(hib_resume_bdev)) {
set_blocksize(hib_resume_bdev, PAGE_SIZE);
hib_resume_bdev_handle = bdev_open_by_dev(swsusp_resume_device,
BLK_OPEN_READ, holder, NULL);
if (!IS_ERR(hib_resume_bdev_handle)) {
set_blocksize(hib_resume_bdev_handle->bdev, PAGE_SIZE);
clear_page(swsusp_header);
error = hib_submit_io(REQ_OP_READ, swsusp_resume_block,
swsusp_header, NULL);
Expand All @@ -1550,11 +1551,11 @@ int swsusp_check(bool exclusive)

put:
if (error)
blkdev_put(hib_resume_bdev, holder);
bdev_release(hib_resume_bdev_handle);
else
pr_debug("Image signature found, resuming\n");
} else {
error = PTR_ERR(hib_resume_bdev);
error = PTR_ERR(hib_resume_bdev_handle);
}

if (error)
Expand All @@ -1570,12 +1571,12 @@ int swsusp_check(bool exclusive)

void swsusp_close(bool exclusive)
{
if (IS_ERR(hib_resume_bdev)) {
if (IS_ERR(hib_resume_bdev_handle)) {
pr_debug("Image device not initialised\n");
return;
}

blkdev_put(hib_resume_bdev, exclusive ? &swsusp_holder : NULL);
bdev_release(hib_resume_bdev_handle);
}

/**
Expand Down

0 comments on commit e017d30

Please sign in to comment.