Skip to content

Commit

Permalink
perf augmented_raw_syscalls: Reduce perf_event_output() boilerplate
Browse files Browse the repository at this point in the history
Add a augmented__output() helper to reduce the boilerplate of sending
the augmented tracepoint to the PERF_EVENT_ARRAY BPF map associated with
the bpf-output event used to communicate with the userspace perf trace
tool.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-ln99gt0j4fv0kw0778h6vphm@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Aug 26, 2019
1 parent c265784 commit e051c2f
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions tools/perf/examples/bpf/augmented_raw_syscalls.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ static inline struct augmented_args_payload *augmented_args_payload(void)
return bpf_map_lookup_elem(&augmented_args_tmp, &key);
}

static inline int augmented__output(void *ctx, struct augmented_args_payload *args, int len)
{
/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(ctx, &__augmented_syscalls__, BPF_F_CURRENT_CPU, args, len);
}

static inline
unsigned int augmented_arg__read_str(struct augmented_arg *augmented_arg, const void *arg, unsigned int arg_len)
{
Expand Down Expand Up @@ -142,8 +148,7 @@ int sys_enter_connect(struct syscall_enter_args *args)

probe_read(&augmented_args->saddr, socklen, sockaddr_arg);

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len + socklen);
return augmented__output(args, augmented_args, len + socklen);
}

SEC("!syscalls:sys_enter_sendto")
Expand All @@ -162,8 +167,7 @@ int sys_enter_sendto(struct syscall_enter_args *args)

probe_read(&augmented_args->saddr, socklen, sockaddr_arg);

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len + socklen);
return augmented__output(args, augmented_args, len + socklen);
}

SEC("!syscalls:sys_enter_open")
Expand All @@ -178,8 +182,7 @@ int sys_enter_open(struct syscall_enter_args *args)

len += augmented_arg__read_str(&augmented_args->arg, filename_arg, sizeof(augmented_args->arg.value));

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len);
return augmented__output(args, augmented_args, len);
}

SEC("!syscalls:sys_enter_openat")
Expand All @@ -194,8 +197,7 @@ int sys_enter_openat(struct syscall_enter_args *args)

len += augmented_arg__read_str(&augmented_args->arg, filename_arg, sizeof(augmented_args->arg.value));

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len);
return augmented__output(args, augmented_args, len);
}

SEC("!syscalls:sys_enter_rename")
Expand All @@ -212,8 +214,7 @@ int sys_enter_rename(struct syscall_enter_args *args)
oldpath_len = augmented_arg__read_str(&augmented_args->arg, oldpath_arg, sizeof(augmented_args->arg.value));
len += oldpath_len + augmented_arg__read_str((void *)(&augmented_args->arg) + oldpath_len, newpath_arg, sizeof(augmented_args->arg.value));

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len);
return augmented__output(args, augmented_args, len);
}

SEC("!syscalls:sys_enter_renameat")
Expand All @@ -230,8 +231,7 @@ int sys_enter_renameat(struct syscall_enter_args *args)
oldpath_len = augmented_arg__read_str(&augmented_args->arg, oldpath_arg, sizeof(augmented_args->arg.value));
len += oldpath_len + augmented_arg__read_str((void *)(&augmented_args->arg) + oldpath_len, newpath_arg, sizeof(augmented_args->arg.value));

/* If perf_event_output fails, return non-zero so that it gets recorded unaugmented */
return perf_event_output(args, &__augmented_syscalls__, BPF_F_CURRENT_CPU, augmented_args, len);
return augmented__output(args, augmented_args, len);
}

SEC("raw_syscalls:sys_enter")
Expand Down

0 comments on commit e051c2f

Please sign in to comment.