Skip to content

Commit

Permalink
drm/nouveau/sched: Don't pass user flags to drm_syncobj_find_fence()
Browse files Browse the repository at this point in the history
The flags field in drm_syncobj_find_fence() takes SYNCOBJ_WAIT flags
from the syncobj UAPI whereas sync->flags is from the nouveau UAPI. What
we actually want is 0 flags which tells it to just try to find the
fence and then return without waiting.

Fixes: b88baab ("drm/nouveau: implement new VM_BIND uAPI")
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>
Reviewed-by: Danilo Krummrich <dakr@redhat.com>
Signed-off-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230807234210.175968-1-faith.ekstrand@collabora.com
  • Loading branch information
Faith Ekstrand authored and Danilo Krummrich committed Aug 8, 2023
1 parent a3540b4 commit e05f393
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/nouveau/nouveau_sched.c
Original file line number Diff line number Diff line change
@@ -142,7 +142,7 @@ sync_find_fence(struct nouveau_job *job,

ret = drm_syncobj_find_fence(job->file_priv,
sync->handle, point,
sync->flags, fence);
0 /* flags */, fence);
if (ret)
return ret;

0 comments on commit e05f393

Please sign in to comment.