Skip to content

Commit

Permalink
hdlx_x25: Fix backwards compat test.
Browse files Browse the repository at this point in the history
drivers/net/wan/hdlc_x25.c: In function ‘x25_ioctl’:
drivers/net/wan/hdlc_x25.c:256:7: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
  256 |   if (ifr->ifr_settings.size = 0) {
      |       ^~~

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jan 21, 2020
1 parent 0159984 commit e09538e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wan/hdlc_x25.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ static int x25_ioctl(struct net_device *dev, struct ifreq *ifr)
return -EBUSY;

/* backward compatibility */
if (ifr->ifr_settings.size = 0) {
if (ifr->ifr_settings.size == 0) {
new_settings.dce = 0;
new_settings.modulo = 8;
new_settings.window = 7;
Expand Down

0 comments on commit e09538e

Please sign in to comment.