Skip to content

Commit

Permalink
bnx2x: Zero VFs starting MACs
Browse files Browse the repository at this point in the history
Hypervisor/Supervisor should set the VF's MAC prior to its load;
Using a randomly generated MAC as a default is a bad practice.

Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ariel Elior authored and David S. Miller committed May 28, 2013
1 parent c48b22d commit e09b74d
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -11406,7 +11406,7 @@ static int bnx2x_init_bp(struct bnx2x *bp)
if (rc)
return rc;
} else {
random_ether_addr(bp->dev->dev_addr);
eth_zero_addr(bp->dev->dev_addr);
}

bnx2x_set_modes_bitmap(bp);
Expand Down Expand Up @@ -11865,6 +11865,10 @@ static int bnx2x_validate_addr(struct net_device *dev)
{
struct bnx2x *bp = netdev_priv(dev);

/* query the bulletin board for mac address configured by the PF */
if (IS_VF(bp))
bnx2x_sample_bulletin(bp);

if (!bnx2x_is_valid_ether_addr(bp, dev->dev_addr)) {
BNX2X_ERR("Non-valid Ethernet address\n");
return -EADDRNOTAVAIL;
Expand Down

0 comments on commit e09b74d

Please sign in to comment.