Skip to content

Commit

Permalink
mtd: rawnand: nandsim: Replace overflow check with kzalloc to single …
Browse files Browse the repository at this point in the history
…kcalloc

Instead of self-checking overflow and allocating an array of specific size
by counting the total required space handy, we already have existed kernel
API which responses for all these works.

Signed-off-by: RinHizakura <s921975628@gmail.com>
Reviewed-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211225100607.118932-1-s921975628@gmail.com
  • Loading branch information
RinHizakura authored and Miquel Raynal committed Jan 23, 2022
1 parent e783362 commit e0a9ddd
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions drivers/mtd/nand/raw/nandsim.c
Original file line number Diff line number Diff line change
Expand Up @@ -979,15 +979,8 @@ static int ns_read_error(unsigned int page_no)

static int ns_setup_wear_reporting(struct mtd_info *mtd)
{
size_t mem;

wear_eb_count = div_u64(mtd->size, mtd->erasesize);
mem = wear_eb_count * sizeof(unsigned long);
if (mem / sizeof(unsigned long) != wear_eb_count) {
NS_ERR("Too many erase blocks for wear reporting\n");
return -ENOMEM;
}
erase_block_wear = kzalloc(mem, GFP_KERNEL);
erase_block_wear = kcalloc(wear_eb_count, sizeof(unsigned long), GFP_KERNEL);
if (!erase_block_wear) {
NS_ERR("Too many erase blocks for wear reporting\n");
return -ENOMEM;
Expand Down

0 comments on commit e0a9ddd

Please sign in to comment.