Skip to content

Commit

Permalink
ipv6: pass up EMSGSIZE msg for UDP socket in Ipv6
Browse files Browse the repository at this point in the history
In ipv4,  when  the machine receives a ICMP_FRAG_NEEDED message,  the
connected UDP socket will get EMSGSIZE message on its next read from the
socket.
However, this is not the case for ipv6.
This fix modifies the udp err handler in Ipv6 for ICMP6_PKT_TOOBIG to
make it similar to ipv4 behavior. That is when the machine gets an
ICMP6_PKT_TOOBIG message, the connected UDP socket will get EMSGSIZE
message on its next read from the socket.

Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wei Wang authored and David S. Miller committed Feb 19, 2016
1 parent 68f2279 commit e0d8c1b
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions net/ipv6/udp.c
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ void __udp6_lib_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
const struct in6_addr *daddr = &hdr->daddr;
struct udphdr *uh = (struct udphdr *)(skb->data+offset);
struct sock *sk;
int harderr;
int err;
struct net *net = dev_net(skb->dev);

Expand All @@ -559,26 +560,27 @@ void __udp6_lib_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
return;
}

harderr = icmpv6_err_convert(type, code, &err);
np = inet6_sk(sk);

if (type == ICMPV6_PKT_TOOBIG) {
if (!ip6_sk_accept_pmtu(sk))
goto out;
ip6_sk_update_pmtu(skb, sk, info);
if (np->pmtudisc != IPV6_PMTUDISC_DONT)
harderr = 1;
}
if (type == NDISC_REDIRECT) {
ip6_sk_redirect(skb, sk);
goto out;
}

np = inet6_sk(sk);

if (!icmpv6_err_convert(type, code, &err) && !np->recverr)
goto out;

if (sk->sk_state != TCP_ESTABLISHED && !np->recverr)
goto out;

if (np->recverr)
if (!np->recverr) {
if (!harderr || sk->sk_state != TCP_ESTABLISHED)
goto out;
} else {
ipv6_icmp_error(sk, skb, err, uh->dest, ntohl(info), (u8 *)(uh+1));
}

sk->sk_err = err;
sk->sk_error_report(sk);
Expand Down

0 comments on commit e0d8c1b

Please sign in to comment.