Skip to content

Commit

Permalink
clk: mediatek: Use right match table, include mod_devicetable
Browse files Browse the repository at this point in the history
This is copy/pasta that breaks modular builds. Fix the match table to
use the right pointer, or the right device table type. And while we're
including the header, fix the order to be linux, dt-bindings, and
finally local.

Cc: Garmin.Chang <Garmin.Chang@mediatek.com>
Cc: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Fixes: f42b9e9 ("clk: mediatek: Add MT8188 wpesys clock support")
Fixes: 0d2f2ce ("clk: mediatek: Add MT8188 adsp clock support")
Fixes: e4aaa60 ("clk: mediatek: Add MT8188 vdosys0 clock support")
Fixes: cfa4609 ("clk: mediatek: Add MT8188 vdosys1 clock support")
Fixes: bb87c11 ("clk: mediatek: Add MT8188 vencsys clock support")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304011039.UBDX1UOT-lkp@intel.com/
Link: https://lore.kernel.org/oe-kbuild-all/202304020649.QO2HlpD5-lkp@intel.com/
Link: https://lore.kernel.org/oe-kbuild-all/202304021055.WDhQPcoS-lkp@intel.com/
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20230404204553.1256263-1-sboyd@kernel.org
  • Loading branch information
Stephen Boyd committed Apr 4, 2023
1 parent 0d2f2ce commit e0e3aca
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 10 deletions.
6 changes: 4 additions & 2 deletions drivers/clk/mediatek/clk-mt8188-adsp_audio26m.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand All @@ -34,7 +36,7 @@ static const struct of_device_id of_match_clk_mt8188_adsp_audio26m[] = {
{ .compatible = "mediatek,mt8188-adsp-audio26m", .data = &adsp_audio26m_desc },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_adsp_audio26m);
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_adsp_audio26m);

static struct platform_driver clk_mt8188_adsp_audio26m_drv = {
.probe = mtk_clk_simple_probe,
Expand Down
6 changes: 4 additions & 2 deletions drivers/clk/mediatek/clk-mt8188-imp_iic_wrap.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand Down Expand Up @@ -65,7 +67,7 @@ static const struct of_device_id of_match_clk_mt8188_imp_iic_wrap[] = {
{ .compatible = "mediatek,mt8188-imp-iic-wrap-en", .data = &imp_iic_wrap_en_desc },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_imp_iic_wrap);
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_imp_iic_wrap);

static struct platform_driver clk_mt8188_imp_iic_wrap_drv = {
.probe = mtk_clk_simple_probe,
Expand Down
4 changes: 3 additions & 1 deletion drivers/clk/mediatek/clk-mt8188-vdo0.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand Down
4 changes: 3 additions & 1 deletion drivers/clk/mediatek/clk-mt8188-vdo1.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand Down
6 changes: 4 additions & 2 deletions drivers/clk/mediatek/clk-mt8188-venc.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand Down Expand Up @@ -39,7 +41,7 @@ static const struct of_device_id of_match_clk_mt8188_venc1[] = {
{ .compatible = "mediatek,mt8188-vencsys", .data = &venc1_desc },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, of_match_clk_mt8188_venc1);
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_venc1);

static struct platform_driver clk_mt8188_venc1_drv = {
.probe = mtk_clk_simple_probe,
Expand Down
6 changes: 4 additions & 2 deletions drivers/clk/mediatek/clk-mt8188-wpe.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
* Author: Garmin Chang <garmin.chang@mediatek.com>
*/

#include <dt-bindings/clock/mediatek,mt8188-clk.h>
#include <linux/clk-provider.h>
#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>

#include <dt-bindings/clock/mediatek,mt8188-clk.h>

#include "clk-gate.h"
#include "clk-mtk.h"

Expand Down Expand Up @@ -88,7 +90,7 @@ static const struct of_device_id of_match_clk_mt8188_wpe[] = {
{ .compatible = "mediatek,mt8188-wpesys-vpp0", .data = &wpe_vpp0_desc },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, clk_mt8188_vpp1_id_table);
MODULE_DEVICE_TABLE(of, of_match_clk_mt8188_wpe);

static struct platform_driver clk_mt8188_wpe_drv = {
.probe = mtk_clk_simple_probe,
Expand Down

0 comments on commit e0e3aca

Please sign in to comment.