Skip to content

Commit

Permalink
memory-failure: convert truncate_error_page to truncate_error_folio
Browse files Browse the repository at this point in the history
Both callers now have a folio, so pass it in.  Nothing downstream was
expecting a tail page; that's asserted in generic_error_remove_page(), for
example.

Link: https://lkml.kernel.org/r/20231117161447.2461643-6-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Matthew Wilcox (Oracle) authored and Andrew Morton committed Dec 11, 2023
1 parent b6fd410 commit e130b65
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions mm/memory-failure.c
Original file line number Diff line number Diff line change
Expand Up @@ -927,14 +927,13 @@ static int delete_from_lru_cache(struct folio *folio)
return -EIO;
}

static int truncate_error_page(struct page *p, unsigned long pfn,
static int truncate_error_page(struct folio *folio, unsigned long pfn,
struct address_space *mapping)
{
struct folio *folio = page_folio(p);
int ret = MF_FAILED;

if (mapping->a_ops->error_remove_page) {
int err = mapping->a_ops->error_remove_page(mapping, p);
int err = mapping->a_ops->error_remove_page(mapping, &folio->page);

if (err != 0)
pr_info("%#lx: Failed to punch page: %d\n", pfn, err);
Expand Down Expand Up @@ -1055,7 +1054,7 @@ static int me_pagecache_clean(struct page_state *ps, struct page *p)
*
* Open: to take i_rwsem or not for this? Right now we don't.
*/
ret = truncate_error_page(p, page_to_pfn(p), mapping);
ret = truncate_error_page(folio, page_to_pfn(p), mapping);
if (has_extra_refcount(ps, p, extra_pins))
ret = MF_FAILED;

Expand Down Expand Up @@ -1189,7 +1188,7 @@ static int me_huge_page(struct page_state *ps, struct page *p)

mapping = folio_mapping(folio);
if (mapping) {
res = truncate_error_page(&folio->page, page_to_pfn(p), mapping);
res = truncate_error_page(folio, page_to_pfn(p), mapping);
/* The page is kept in page cache. */
extra_pins = true;
folio_unlock(folio);
Expand Down

0 comments on commit e130b65

Please sign in to comment.